Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POWEROPS-1842 - Unify SHOP clients and classes in SDK #402

Merged
merged 16 commits into from
Aug 12, 2024
Merged

Conversation

cpnat
Copy link
Contributor

@cpnat cpnat commented Aug 4, 2024

Description

Restructure the functionality to interact with SHOP. Old versus new structure illustrated below:

Old
image

New
image

Changes:

  • Restructure code, as above. Leaves only what is referenced in the power-ops-sdk and example notebooks
  • Update mkdocs to reflect the current structure
  • Update and test the provided example notebooks

Checklist:

@cpnat cpnat changed the title Initial round deletions POWEROPS-1842 - Unify SHOP clients and classes in SDK Aug 4, 2024
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 61.61137% with 81 lines in your changes missing coverage. Please review.

Project coverage is 48.89%. Comparing base (783c717) to head (98807fa).

Files Patch % Lines
...nite/powerops/client/shop/data_classes/shop_run.py 55.00% 72 Missing ⚠️
cognite/powerops/utils/helpers.py 57.14% 3 Missing ⚠️
.../powerops/client/shop/data_classes/shop_results.py 75.00% 2 Missing ⚠️
cognite/powerops/client/shop/shop_run_api.py 75.00% 2 Missing ⚠️
...owerops/client/shop/data_classes/shop_run_event.py 80.00% 1 Missing ⚠️
...werops/client/shop/data_classes/shop_run_filter.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #402      +/-   ##
==========================================
- Coverage   49.03%   48.89%   -0.15%     
==========================================
  Files         575      566       -9     
  Lines       40759    40271     -488     
==========================================
- Hits        19987    19691     -296     
+ Misses      20772    20580     -192     
Files Coverage Δ
cognite/powerops/_version.py 100.00% <100.00%> (ø)
cognite/powerops/client/powerops_client.py 86.95% <100.00%> (ø)
cognite/powerops/client/shop/__init__.py 100.00% <100.00%> (ø)
...nite/powerops/client/shop/data_classes/__init__.py 100.00% <100.00%> (ø)
...erops/client/shop/data_classes/dayahead_trigger.py 89.32% <100.00%> (ø)
...ite/powerops/client/shop/data_classes/shop_case.py 83.92% <100.00%> (ø)
...ps/client/shop/data_classes/shop_file_reference.py 85.18% <100.00%> (ø)
...rops/client/shop/data_classes/shop_result_files.py 38.29% <100.00%> (ø)
...gnite/powerops/client/shop/dayahead_trigger_api.py 36.95% <100.00%> (ø)
cognite/powerops/resync/models/v1/cogshop.py 67.01% <100.00%> (ø)
... and 10 more

... and 89 files with indirect coverage changes

nodegard
nodegard previously approved these changes Aug 12, 2024
Copy link
Contributor

@nodegard nodegard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of clean up 🫶🏻 looks good

@cpnat cpnat merged commit 7dd0558 into main Aug 12, 2024
6 checks passed
@cpnat cpnat deleted the remove-shop-dupe branch August 12, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants