Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add_iter_method_on_state_store #260

Merged
merged 4 commits into from
Nov 10, 2023
Merged

Conversation

cel055
Copy link
Contributor

@cel055 cel055 commented Nov 9, 2023

added the method iter on state store that will return the keys of the dict

@cel055 cel055 requested a review from a team as a code owner November 9, 2023 13:16
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #260 (d7656a5) into master (f995275) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #260      +/-   ##
==========================================
+ Coverage   78.61%   78.66%   +0.05%     
==========================================
  Files          22       22              
  Lines        1917     1922       +5     
==========================================
+ Hits         1507     1512       +5     
  Misses        410      410              
Files Coverage Δ
cognite/extractorutils/__init__.py 100.00% <100.00%> (ø)
cognite/extractorutils/statestore.py 91.35% <100.00%> (+0.69%) ⬆️

... and 2 files with indirect coverage changes

Copy link
Collaborator

@mathialo mathialo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great to see a test too :)

@@ -309,6 +309,10 @@ def __contains__(self, external_id: str) -> bool:
def __len__(self) -> int:
return len(self._local_state)

def __iter__(self) -> Iterable:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include the type for the items as well

Suggested change
def __iter__(self) -> Iterable:
def __iter__(self) -> Iterable[str]:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all set

@cel055 cel055 requested a review from mathialo November 9, 2023 13:57
@cel055 cel055 merged commit eeed8fa into master Nov 10, 2023
@cel055 cel055 deleted the add_iter_method_on_state_store branch November 10, 2023 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants