Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Keyvault support #268

Merged
merged 17 commits into from
Jan 11, 2024
Merged

Azure Keyvault support #268

merged 17 commits into from
Jan 11, 2024

Conversation

rsjr
Copy link
Contributor

@rsjr rsjr commented Nov 28, 2023

Adding Azure Keyvault support

@rsjr rsjr changed the title Keyvault Azure Keyvault support Nov 28, 2023
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Merging #268 (190e711) into master (dc7cf3e) will increase coverage by 0.08%.
The diff coverage is 83.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #268      +/-   ##
==========================================
+ Coverage   78.61%   78.70%   +0.08%     
==========================================
  Files          22       22              
  Lines        1913     1972      +59     
==========================================
+ Hits         1504     1552      +48     
- Misses        409      420      +11     
Files Coverage Δ
cognite/extractorutils/__init__.py 100.00% <100.00%> (ø)
cognite/extractorutils/configtools/loaders.py 74.73% <83.05%> (+3.41%) ⬆️

... and 2 files with indirect coverage changes

@rsjr rsjr marked this pull request as ready for review November 29, 2023 11:09
@rsjr rsjr requested a review from a team as a code owner November 29, 2023 11:09
@rsjr rsjr requested a review from mathialo January 8, 2024 08:28
@rsjr rsjr merged commit d166116 into master Jan 11, 2024
6 checks passed
@rsjr rsjr deleted the keyvault branch January 11, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants