Improve runtime startup #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve error handling for loading configs, roll back to previous versions if a version is invalid. Report errors back to integrations if a CDF-hosted application config fails to load. Improve error handling overall, with better error messages relayed to the end user. Do a connection check at startup to make sure the connection config is valid, with good error messages.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #404 +/- ##
==========================================
- Coverage 76.41% 74.46% -1.96%
==========================================
Files 40 41 +1
Lines 3210 3313 +103
==========================================
+ Hits 2453 2467 +14
- Misses 757 846 +89
|
einarmo
approved these changes
Dec 2, 2024
| @@ -139,7 +139,7 @@ class ConnectionConfig(ConfigModel): | |||
| project: str | |||
| base_url: str | |||
|
|
|||
| extraction_pipeline: str | |||
| integration: str | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve error handling for loading configs, roll back to previous versions if a version is invalid. Report errors back to integrations if a CDF-hosted application config fails to load.
Improve error handling overall, with better error messages relayed to the end user.
Do a connection check at startup to make sure the connection config is valid, with good error messages.