Switch build system to hatchling #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setuptools produces straight-up invalid wheel files. From PyPI when trying to publish: ``` Upload failed with status code 400 Bad Request. Server says: 400 license-file introduced in metadata version 2.4, not 2.2. See https://packaging.python.org/specifications/core-metadata for more information. ``` I tried rebuilding the packages locally, and saw the same discrepancy in the wheel file. Hatchling gets it right, it's also much nicer to configure.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #421 +/- ##
=======================================
Coverage 75.54% 75.54%
=======================================
Files 41 41
Lines 3398 3398
=======================================
Hits 2567 2567
Misses 831 831 |
einarmo
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setuptools produces straight-up invalid wheel files. From PyPI when trying to publish:
I tried rebuilding the packages locally, and saw the same discrepancy in the wheel file. Hatchling gets it right, it's also much nicer to configure.