Reduce potential problems #89
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was quite irritating that the autocmd tried to close all the windows generated by agit. Typical problematic cases are below: - `:tabonly` at another tab. - `:tabclose` at the agit tab. - `:only` at the agit tab to concentrate an agit buffer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename the variables that were too simply named.
They were exposed having risks to conflict with other variables possibly defined outside agit.vim.
Remove the autocmd on
QuitPreto exit.That could disturb us closing extra windows on such cases as below:
:tabonlyat another tab.:tabcloseat the agit tab.:onlyto concentrate an agit buffer or another buffer which's been opened in the same tab.By the way, what is the reason to copy
winfromw:beforehas_key(win, foo)(not justhas_key(w:, foo))?