check api key on client init #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimwu6
reviewed
Jan 5, 2022
example/main.go
Outdated
| co := cohere.CreateClient(apiKey) | ||
| co, err := cohere.CreateClient(apiKey) | ||
| if err != nil { | ||
| fmt.Println("invalid api key") |
There was a problem hiding this comment.
we should probably just print the error here, since it could be a network issue or api issue
kipply
reviewed
Jan 5, 2022
| @@ -49,6 +70,7 @@ func (c *Client) post(model string, endpoint string, body interface{}) ([]byte, | |||
|
|
|||
| req.Header.Set("Authorization", "BEARER "+c.APIKey) | |||
| req.Header.Set("Content-Type", "application/json") | |||
| req.Header.Set("Request-Source", "go-sdk") | |||
kipply
approved these changes
Jan 5, 2022
CoderHam
pushed a commit
that referenced
this pull request
Jul 19, 2022
- It was changed to also return error in #7
CoderHam
pushed a commit
that referenced
this pull request
Jul 19, 2022
- function signature was changed to also return error in #7
CoderHam
pushed a commit
that referenced
this pull request
Jul 20, 2022
- function signature was changed to also return error in #7
CoderHam
added a commit
that referenced
this pull request
Jul 21, 2022
* Fix CreateClient usage in ReadMe - function signature was changed to also return error in #7 * Add error checking and logging for CreateClient to ReadMe example * replace tabs with spaces Co-authored-by: CoderHam <hemanham@gmail.ßcom>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added check for api key validity on client init with tests.