Skip to content

Commit

Permalink
Remove old todos and update todos with github user
Browse files Browse the repository at this point in the history
  • Loading branch information
wujessica committed Apr 29, 2024
1 parent 51ddb20 commit 5589280
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,6 @@ export const CitationDocument: React.FC<Props> = ({ document, isExpandable = fal
{isExpanded && isExpandable && (
<div className="flex flex-col">
{getSnippet(30, 'line-clamp-3')}
{/* TODO(jessica): should we enable this/will we support this? */}
<button
className="self-end p-0 text-primary-900 transition-colors ease-in-out hover:text-primary-700"
onClick={openFullSnippetModal}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@ export const CitationTextHighlighter: React.FC<Props> = ({
generationId={generationId}
// Used to find the keyword to bold but since we don't have it yet here when the message is
// still streaming in we can just ignore it for now instead of not showing the popup at all
// TODO(jessica): pass in cited text from citation event as a backup
message={message?.originalText ?? ''}
/>
),
Expand Down
4 changes: 2 additions & 2 deletions src/interfaces/coral_web/src/hooks/chat.ts
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,7 @@ export const useChat = (config?: { onSend?: (msg: string) => void }) => {

const finalText = isRAGOn
? replaceTextWithCitations(
// TODO(jessica): temporarily use the text generated from the stream when MAX_TOKENS
// TODO(@wujessica): temporarily use the text generated from the stream when MAX_TOKENS
// because the final response doesn't give us the full text yet. Note - this means that
// citations will only appear for the first 'block' of text generated.
data?.finish_reason === FinishReason.FINISH_REASON_MAX_TOKENS
Expand All @@ -309,7 +309,7 @@ export const useChat = (config?: { onSend?: (msg: string) => void }) => {
type: MessageType.BOT,
state: BotState.FULFILLED,
generationId,
// TODO(jessica): TEMPORARY - we don't pass citations for langchain multihop right now
// TODO(@wujessica): TEMPORARY - we don't pass citations for langchain multihop right now
// so we need to manually apply this fix. Otherwise, this comes for free when we call
// `replaceTextWithCitations`.
text: citations.length > 0 ? finalText : fixMarkdownImagesInText(finalText),
Expand Down
4 changes: 1 addition & 3 deletions src/interfaces/coral_web/src/themes/cohereTheme.js
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
const defaultTheme = require('tailwindcss/defaultTheme');

// any changes to the theme should be reflected into our `customTwMerge` in `utils/cn.ts`
// Any changes to the theme should be reflected into our `customTwMerge` in `utils/cn.ts`
module.exports = {
theme: {
extend: {
// TODO(jessica): shift colors to `extend` for now so that using the old theme and nature theme
// merge nicely
colors: {
transparent: 'transparent',
pureWhite: '#FFFFFF',
Expand Down

0 comments on commit 5589280

Please sign in to comment.