-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minro refactoring for consistancy sake #102
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch! Thanks for contributing
I see one of the commits is not signed so you won't be able to merge the PR as is. To fix this, you can run the following command to sign all the commit history:
|
". 2. The description should provide more details about the changes made in the pull request. It should also be concise and start with " " and end with "
Good morning,I have signed my commit. Please let me know if there is anything else I need to do.BTW, I enjoyed browsing the toolkit source code and learned a lot from it.Have a wonderful day,Payman Sent from my iPhoneOn May 8, 2024, at 5:18 AM, Luísa Moura ***@***.***> wrote:
I see one of the commits is not signed so you won't be able to merge the PR as is. To fix this, you can run the following command to sign all the commit history:
exec git commit --amend --no-edit -S
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Hey @Phodaie! Thanks for checking out and contributing to Toolkit! Seems like your commits are still unverified. Check out https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits for more info about signing commits! |
@Phodaie looks good now. merging this in! thanks for your contribution :) |
".
" and end with "