Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minro refactoring for consistancy sake #102

Merged
merged 3 commits into from
May 10, 2024
Merged

Conversation

Phodaie
Copy link
Contributor

@Phodaie Phodaie commented May 4, 2024

".

  1. The description should provide more details about the changes made in the pull request. It should also be concise and start with "

" and end with "

@Phodaie Phodaie requested a review from a team as a code owner May 4, 2024 15:34
@CLAassistant
Copy link

CLAassistant commented May 4, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@lusmoura lusmoura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thanks for contributing

@lusmoura
Copy link
Collaborator

lusmoura commented May 8, 2024

I see one of the commits is not signed so you won't be able to merge the PR as is. To fix this, you can run the following command to sign all the commit history:

git rebase --exec 'git commit --amend --no-edit -n -S' -i --root

".

2. The description should provide more details about the changes made in the pull request. It should also be concise and start with "

" and end with "
@Phodaie
Copy link
Contributor Author

Phodaie commented May 8, 2024 via email

@scott-cohere
Copy link
Contributor

Hey @Phodaie! Thanks for checking out and contributing to Toolkit! Seems like your commits are still unverified. Check out https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits for more info about signing commits!

@scott-cohere
Copy link
Contributor

@Phodaie looks good now. merging this in! thanks for your contribution :)

@scott-cohere scott-cohere merged commit 3293bd4 into cohere-ai:main May 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants