Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend: Fix #97, change default python interpreter URL to http://terrarium:8080 #103

Merged
merged 2 commits into from
May 8, 2024

Conversation

acanis
Copy link
Contributor

@acanis acanis commented May 6, 2024

Description: The previous default python interpreter URL http://localhost:8080 didn't work with docker compose on Mac. Changing to terrarium (name of the Docker container running Python interpreter API endpoint) fixed the frontend.
Issue: #97
Dependencies: N/A

  • Add tests and docs: Updated README
  • [] Lint and test: Run make lint and make run-tests. Need to run CI, these didn't work locally for me.

…rarium:8080

The previous default http://localhost:8080 didn't work with docker
compose on Mac
@acanis acanis requested a review from a team as a code owner May 6, 2024 02:26
@CLAassistant
Copy link

CLAassistant commented May 6, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@tianjing-li tianjing-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@lusmoura
Copy link
Collaborator

lusmoura commented May 8, 2024

Merging to avoid the need to update the branch again!

@lusmoura lusmoura merged commit 94edcbb into cohere-ai:main May 8, 2024
2 checks passed
lakshyaag pushed a commit to lakshyaag/cohere-toolkit that referenced this pull request May 8, 2024
…http://terrarium:8080 (cohere-ai#103)

Fix cohere-ai#97: Change default python interpreter URL to http://terrarium:8080

The previous default http://localhost:8080 didn't work with docker
compose on Mac

Co-authored-by: Tianjing Li <tianjinglimail@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants