-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
coral-web: modal to edit deployment env variables #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wujessica
force-pushed
the
jw/edit-env-variables-modal
branch
from
May 7, 2024 21:08
8e3ecee
to
d7b3adc
Compare
misspia-cohere
approved these changes
May 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
niceee
src/interfaces/coral_web/src/components/EditEnvVariablesButton.tsx
Outdated
Show resolved
Hide resolved
Shared/ is for generic UI components
wujessica
force-pushed
the
jw/edit-env-variables-modal
branch
from
May 14, 2024 18:42
d7b3adc
to
362e6ec
Compare
wujessica
requested review from
EugeneLightsOn,
malexw,
scottmx81 and
tianjing-li
as code owners
May 14, 2024 18:42
tianjing-li
approved these changes
May 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
misspia-cohere
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds a modal for users to update env variables from the UI.
Tests:
Screen.Recording.2024-05-07.at.4.04.44.PM.mov