Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: add alembic troubleshooting #181

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Conversation

lusmoura
Copy link
Collaborator

@lusmoura lusmoura commented Jun 6, 2024

AI Description

This pull request updates the workflow to check for duplicate revision IDs and adds troubleshooting documentation for an Alembic error.

Changes

  • Updated the paths for both pull_request and push events in the check_revision_id.yml workflow to include all files in the src/backend/alembic/versions/ directory.
  • Added a new section in troubleshooting.md to address an Alembic error that may occur when running the make migrate command. The section provides a solution by suggesting additional commands to run before rerunning the make migrate command.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@d0459af). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #181   +/-   ##
=======================================
  Coverage        ?   87.97%           
=======================================
  Files           ?      126           
  Lines           ?     3993           
  Branches        ?        0           
=======================================
  Hits            ?     3513           
  Misses          ?      480           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/troubleshooting.md Outdated Show resolved Hide resolved
docs/troubleshooting.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@tianjing-li tianjing-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just added changes to the wording, good to go!

@tianjing-li
Copy link
Collaborator

@lusmoura merging this for you

@tianjing-li tianjing-li merged commit 3b5f94f into main Jun 7, 2024
1 of 2 checks passed
@tianjing-li tianjing-li deleted the luisa/fix_revision_check branch June 7, 2024 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants