Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove enforced auth token for /user endpoints #182

Merged
merged 7 commits into from
Jun 7, 2024
Merged

Remove enforced auth token for /user endpoints #182

merged 7 commits into from
Jun 7, 2024

Conversation

tianjing-li
Copy link
Collaborator

  • Removes the validation for Authorization: Bearer for user endpoints to allow creating users

malexw
malexw approved these changes Jun 7, 2024
View reviewed changes
Copy link
Collaborator

@malexw malexw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice that with this change, endpoint for listing all users, getting user details, and deleting users are all unprotected. I assume that this is just temporary and we'll be adding more detailed permissions around these with the addition of organizations?

@tianjing-li tianjing-li merged commit 95fcd0f into main Jun 7, 2024
1 of 2 checks passed
@tianjing-li tianjing-li deleted the remove-user-auth branch June 7, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malexw malexw malexw approved these changes

@EugeneLightsOn EugeneLightsOn Awaiting requested review from EugeneLightsOn EugeneLightsOn is a code owner

@scottmx81 scottmx81 Awaiting requested review from scottmx81 scottmx81 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tianjing-li @malexw