[backend] make deployment field optional in API and DB #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scott-cohere
requested review from
EugeneLightsOn,
malexw,
scottmx81,
tianjing-li and
a team
as code owners
misspia-cohere
approved these changes
Jun 14, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #213 +/- ##
=======================================
Coverage ? 88.14%
=======================================
Files ? 137
Lines ? 4545
Branches ? 0
=======================================
Hits ? 4006
Misses ? 539
Partials ? 0 ☔ View full report in Codecov by Sentry. |
ClaytonSmith
added a commit
to MiniMap-ai/cohere-toolkit
that referenced
this pull request
Jun 17, 2024
* [backend] make deployment field optional in API and DB (cohere-ai#213) --------- Co-authored-by: Tianjing Li <tianjinglimail@gmail.com> Co-authored-by: Tomeu <tomeu@cohere.com> Co-authored-by: Scott <146760070+scott-cohere@users.noreply.github.com> Co-authored-by: Beatrix De Wilde <128378696+BeatrixCohere@users.noreply.github.com>
ClaytonSmith
added a commit
to MiniMap-ai/cohere-toolkit
that referenced
this pull request
Jun 17, 2024
* [coral-web] rename schema fields and update openapi client (cohere-ai#189) * update * update client * Add use agents view env variable. (cohere-ai#192) * Change * Format * [backend] api_key not set for class methods (cohere-ai#191) * fix * easier fix * perf: downgrade rehype-highlight and generate once blob url (cohere-ai#193) * perf: downgrade rehype-highlight and generate once blob url * fix: replace code blocks to iframe in conversation history * refactor: run format * refactor: pr feedback * Add OIDC auth strategy, add Blacklist scaffolding (model/schema/crud) (cohere-ai#190) * add oidc, blacklist logic * Add auth * Add logic for GET /auth * Mods * fix: html preview with citations (cohere-ai#200) * [backend] adding tools for agents, filter tools by agent_id (cohere-ai#204) * changes * lint * filter tools by agent * lint * update tests * lint and squash migrations * fix alembic migration err * lint * merge (#3) * [backend] make deployment field optional in API and DB (cohere-ai#213) --------- Co-authored-by: Tianjing Li <tianjinglimail@gmail.com> Co-authored-by: Tomeu <tomeu@cohere.com> Co-authored-by: Scott <146760070+scott-cohere@users.noreply.github.com> Co-authored-by: Beatrix De Wilde <128378696+BeatrixCohere@users.noreply.github.com> * pulling from main * cleaned backend docker image push * syncing with main (conflicts) --------- Co-authored-by: Scott <146760070+scott-cohere@users.noreply.github.com> Co-authored-by: Beatrix De Wilde <128378696+BeatrixCohere@users.noreply.github.com> Co-authored-by: Tomeu <tomeu@cohere.com> Co-authored-by: Tianjing Li <tianjinglimail@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For v1 we don't need to be concerned about deployment type. To unblock FE I've made it optional here and defaulting the DB value to
COHERE_PLATFORMand updated the unit tests accordingly. Also generating new client for FE.AI Description
This PR introduces changes to the Agent model and associated tests. The
deploymentfield is now optional and can be set tonull. Additionally, a newtoolsfield has been added, which is an array ofToolNameenums. This enum includes options such as 'Wikipedia', 'search_file', and 'Python_Interpreter'.The following changes have been made:
deploymentfield in theAgentmodel is now optional and can benull.toolsfield has been added to theAgentmodel, which is an array ofToolNameenums.CreateAgentandUpdateAgenttypes to include the newtoolsfield and make thedeploymentfield optional.Authtype and added new types forJWTResponse,ListAuthStrategy, andLogout.DefaultServiceclass to use the new types and handle the optionalagentIdparameter in thelistToolsV1ToolsGetmethod.test_create_agent_missing_deploymenttest cases as they are no longer applicable with the optionaldeploymentfield.