Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github actions: add build + lint check workflow for coral_web #81

Conversation

misspia-cohere
Copy link
Contributor

@misspia-cohere misspia-cohere commented Apr 30, 2024

Adds build and lint check workflow for coral_web

@misspia-cohere misspia-cohere requested a review from a team as a code owner April 30, 2024 21:00
@misspia-cohere misspia-cohere marked this pull request as draft April 30, 2024 21:01
@misspia-cohere misspia-cohere force-pushed the pia/cnv-1936-add-github-actions-for-build-lint-checks-in-coral-web branch from 76cb594 to f0aee0f Compare April 30, 2024 21:03
@misspia-cohere misspia-cohere changed the title [WIP] github actions: add workflow for coral_web [WIP] github actions: add build + lint check workflow for coral_web May 1, 2024
@misspia-cohere misspia-cohere changed the title [WIP] github actions: add build + lint check workflow for coral_web github actions: add build + lint check workflow for coral_web May 1, 2024
@misspia-cohere misspia-cohere marked this pull request as ready for review May 1, 2024 17:44
Copy link
Collaborator

@tianjing-li tianjing-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow!

.github/actions/js-install/actions.yml Outdated Show resolved Hide resolved
.github/actions/js-install/actions.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@wujessica wujessica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@misspia-cohere misspia-cohere merged commit 73526a5 into main May 8, 2024
2 checks passed
@misspia-cohere misspia-cohere deleted the pia/cnv-1936-add-github-actions-for-build-lint-checks-in-coral-web branch May 8, 2024 18:05
lakshyaag pushed a commit to lakshyaag/cohere-toolkit that referenced this pull request May 8, 2024
…-ai#81)

* add coral_web workflow

* add path filter

* setup node, pnpm and install deps before running checks

* update node version file path

* update actions paths/directories
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants