-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependencies are stale #2
Comments
Disabling the persistent strategy works around the issue, so it can be closed. We'll want to track a more permanent solution and re-enable re-used environments, but that's something that can wait. |
I noticed you re-opened this issue. I wasn't really sure why. Now I realize it was I mistakenly pointed to this issue instead of another. Glad to see you making some progress on a more permanent solution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In an attempt to re-use unchanged dependencies, the test runner invokes the persistent strategy:
coherent.test/__main__.py
Line 11 in aaacd57
Unfortunately, the way that strategy is implemented, it keys the environment on the requirements, which are always
.[test]
(even across projects), meaning that from run to run, the same environment is used even if the dependencies (or project under test) have changed, leading to ImportErrors when those dependencies are used.Probably, the pip-run persistent strategy should resolve the dependencies and then key on the solved dependency tree... or at least key on the resolution of the indicated dependencies (i.e. expand
requirements.txt
and dependencies implied by local paths).The text was updated successfully, but these errors were encountered: