Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch release 0.1.1 pining bokeh #530

Closed
2 tasks done
ncclementi opened this issue Nov 15, 2022 · 6 comments
Closed
2 tasks done

Patch release 0.1.1 pining bokeh #530

ncclementi opened this issue Nov 15, 2022 · 6 comments
Assignees

Comments

@ncclementi
Copy link
Contributor

ncclementi commented Nov 15, 2022

It's not clear that we can do a release 0.2.0 bumping up all the packages see

However, due to the unpin version of bokeh in distributed the current runtime breaks the dashboard see #520.

Action items.

  • Reverting the packages version of the runtime to the versions in 0.1.0 and add bokeh=2.4.3
  • Do a release
@dchudz
Copy link
Collaborator

dchudz commented Nov 17, 2022

+1

@dchudz
Copy link
Collaborator

dchudz commented Nov 17, 2022

Reverting the packages version of the runtime to the versions in 0.1.0 and add bokeh=2.4.3

Do you really have to revert?

I'd expect the easiest we to do this kind of patch release is:

  1. branch off the 0.1.0 tag
  2. update the bokeh pin and tag as 0.1.1
  3. release that

@ncclementi
Copy link
Contributor Author

@dchudz there is already a plan of action, we don't want to do a release without reverting the updates because there are some broken things on newer versions plus some regressions we don't yet understand. If you want to learn more about that, read #526 but more specifically #500.

The release was a bit delayed due to other issues but now we should be good to go. I'll have the release done in the next hour, have a few things to take care of first.

@jrbourbeau
Copy link
Member

@dchudz was just proposing an implementation for the same thing that wouldn't have required changes to main. In retrospect, @dchudz's suggestion is probably more lightweight than what we're doing. That said, since we've already reverted packages in main, let's just keep with the current plan.

The release was a bit delayed due to other issues but now we should be good to go. I'll have the release done in the next hour, have a few things to take care of first.

Cool -- thanks for handing this @ncclementi

@ncclementi
Copy link
Contributor Author

Closing as the release has been done in both pypi and conda-forge

@jrbourbeau
Copy link
Member

Woo -- thanks @ncclementi!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants