Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin bokeh and coiled for 0.1.1 release #524

Merged
merged 5 commits into from
Nov 17, 2022
Merged

Pin bokeh and coiled for 0.1.1 release #524

merged 5 commits into from
Nov 17, 2022

Conversation

ncclementi
Copy link
Contributor

@ncclementi ncclementi commented Nov 14, 2022

see #530

@jrbourbeau this should be a quick review.

@ncclementi ncclementi changed the title [DNM] Revert all but dask and coiled Pin bokeh and coiled for 0.1.1 release Nov 15, 2022
@@ -1,7 +1,7 @@
{% set name = "coiled-runtime" %}
{% set version = "0.2.0" + environ.get("VERSION_SUFFIX", '') %}
{% set dask_version = environ.get("DASK_VERSION", "2022.10.2") %}
{% set distributed_version = environ.get("DISTRIBUTED_VERSION", "2022.10.2") %}
{% set dask_version = environ.get("DASK_VERSION", "2022.6.0") %}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jrbourbeau since we are doing a patch, should we bump to 2022.6.1 see #306
cc: @hendrikmakait

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's stick with 2022.6.0 to keep this PR as minimal as possible. I expect we'll push out another release soon where we update other package versions

@@ -23,34 +23,34 @@ requirements:
- python >=3.8,<3.11
- pip
- coiled >=0.2.41
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm leaving this in as a protective measure

@ncclementi ncclementi marked this pull request as ready for review November 15, 2022 22:17
@ncclementi
Copy link
Contributor Author

It looks like a lot of things are broken, but not related to this PR necessarily. Is hard to tell what's happening here.

@jrbourbeau
Copy link
Member

@ncclementi I merged main to see if #514 will fix the CI failures we were seeing (there's a chance it does)

@ncclementi
Copy link
Contributor Author

@ncclementi I merged main to see if #514 will fix the CI failures we were seeing (there's a chance it does)

You beat me to it. : )

@ncclementi
Copy link
Contributor Author

It's not clear to me what the Assertion errors we have are. @jrbourbeau It seems it comes from the scheduler, any ideas?

@ntabris
Copy link
Member

ntabris commented Nov 16, 2022

Current failure (https://github.com/coiled/coiled-runtime/actions/runs/3483410547/jobs/5826865040) doesn't look related to #514, looks like it could be a genuine issue related to scheduler.restart().

The failed assertion is https://github.com/dask/distributed/blob/69b74f9f0aa46dac7facb960f1b0aaac69121e5e/distributed/scheduler.py#L5805

@fjetter has been working on things related to restart.

@ncclementi
Copy link
Contributor Author

Since the error is only happening in upstream, and this release only affects the non-upstream things, I will go ahead and merge this to proceed with the patch release

Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ncclementi -- I agree for the patch release, the upstream failure isn't relevant

@jrbourbeau jrbourbeau merged commit f83e68c into main Nov 17, 2022
@jrbourbeau jrbourbeau deleted the revert-update-ver branch November 17, 2022 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants