Add TPC-H query 8 for Dask #1180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milesgranger
changed the title
milesgranger
force-pushed
the
milesgranger/add-polars-q8
branch
from
7657866 to
dcd509a
Compare
IndexError: Column(s) nation already selected
milesgranger
force-pushed
the
milesgranger/add-polars-q8
branch
from
dcd509a to
b36b2cd
Compare
milesgranger
commented
Oct 31, 2023
milesgranger
force-pushed
the
milesgranger/add-polars-q8
branch
from
74431e7 to
aed7445
Compare
milesgranger
force-pushed
the
milesgranger/add-polars-q8
branch
from
aed7445 to
94733eb
Compare
|
I care about it less now that the initial push for PyData NYC is over. I
still care generally about expanding benchmark coverage. Maybe that's more
TPC-H or maybe it's some other benchmark suite, like TPC-DS. I'd encourage
folks like yourself and @fjetter and @phofl to figure out what might be
best here.
…On Tue, Nov 21, 2023 at 3:45 AM Miles ***@***.***> wrote:
@mrocklin <https://github.com/mrocklin> @phofl <https://github.com/phofl>
Do we still want this?
—
Reply to this email directly, view it on GitHub
<#1180 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACKZTCCQ35WCMUZAPK4YDLYFRZ3TAVCNFSM6AAAAAA6XH2R56VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRQGU3DSMZVGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
<https://coiled.io>
Matthew Rocklin CEO, Dask Maintainer
|
|
Query 8 is a good guinea pig for
dask/dask-expr#386
On Tue, Nov 21, 2023 at 2:58 PM Matthew Rocklin ***@***.***>
wrote:
… I care about it less now that the initial push for PyData NYC is over. I
still care generally about expanding benchmark coverage. Maybe that's more
TPC-H or maybe it's some other benchmark suite, like TPC-DS. I'd encourage
folks like yourself and @fjetter and @phofl to figure out what might be
best here.
On Tue, Nov 21, 2023 at 3:45 AM Miles ***@***.***> wrote:
> @mrocklin <https://github.com/mrocklin> @phofl <https://github.com/phofl>
> Do we still want this?
>
> —
> Reply to this email directly, view it on GitHub
> <#1180 (comment)>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AACKZTCCQ35WCMUZAPK4YDLYFRZ3TAVCNFSM6AAAAAA6XH2R56VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRQGU3DSMZVGA>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
--
<https://coiled.io>
Matthew Rocklin CEO, Dask Maintainer
—
Reply to this email directly, view it on GitHub
<#1180 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOYQZGAM2Q423SUNJGO5OGLYFSXP5AVCNFSM6AAAAAA6XH2R56VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRQHE3TMOJRGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Is there any work left here? |
hendrikmakait
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add query 8 as requested in #1071