-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Run test suite on arbitrary coiled environments #296
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| # Sample conda environment file for A/B testing | ||
| # It *must* be called AB_<name>.conda.yaml | ||
| # and *must* be accompanied by AB_<name>.dask.yaml | ||
| channels: | ||
| - conda-forge | ||
| dependencies: | ||
| - python=3.9 | ||
| # Alternatively, we could use a nightly build, or no coiled-runtime at all | ||
| - coiled-runtime=0.1.0 | ||
| - pip: | ||
| # Notes: | ||
| # - You can't install anything with conda which conflicts the versions | ||
| # pinned in coiled-runtime. Pip packages ignore these restrictions. | ||
| # - You can point to your own git fork instead | ||
| - dask==2022.8.1 | ||
| - git+https://github.com/dask/distributed@dd81b424971e81616e1a52fa09ce4698a5002d41 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| # Sample dask config file for A/B testing | ||
| # It *must* be called AB_<name>.dask.yaml | ||
| # and *must* be accompanied by AB_<name>.conda.yaml | ||
| # Leave empty if you don't want to override anything. | ||
| distributed: | ||
| scheduler: | ||
| worker-saturation: 1.2 | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| #!/usr/bin/env python | ||
| """Read a dask config file and print it out in the format `-e ENV=VALUE ENV=VALUE ...` | ||
| This script is a work-around to not being able to upload dask config files to | ||
| `conda env create`. | ||
| """ | ||
| from __future__ import annotations | ||
|
|
||
| import sys | ||
| from typing import Iterator | ||
|
|
||
| import yaml | ||
|
|
||
|
|
||
| def main(fname: str) -> None: | ||
| with open(fname) as fh: | ||
| cfg = yaml.safe_load(fh) | ||
| # Print nothing in case of empty file, comments only, or empty dict | ||
| if cfg: | ||
| print("-e " + " ".join(traverse(cfg, []))) | ||
|
|
||
|
|
||
| def traverse(node: dict | list | str | float | None, path: list[str]) -> Iterator[str]: | ||
| if isinstance(node, dict): | ||
| for k, v in node.items(): | ||
| k = k.upper().replace("-", "_") | ||
| yield from traverse(v, path + [k]) | ||
| return | ||
|
|
||
| if not path: | ||
| raise ValueError("The top-level element must be a dict") | ||
| if isinstance(node, str) and "'" in node: | ||
| raise ValueError("Unsupported character: ' (single quote)") | ||
|
|
||
| yield "'DASK_" + "__".join(path) + f"={node}'" | ||
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| main(sys.argv[1]) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The alternative to forcing the developer to create an empty file every time was to ignore the file if it doesn't exist, but the risk of misspellings producing unexpected results was too high. Explicit is better than implicit.