Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeat A/B tests #324

Closed
wants to merge 1 commit into from
Closed

Repeat A/B tests #324

wants to merge 1 commit into from

Conversation

crusaderky
Copy link
Contributor

No description provided.

@crusaderky crusaderky force-pushed the guido/AB_repeat branch 4 times, most recently from d7f1d16 to 2ad2a80 Compare September 13, 2022 11:44
@crusaderky crusaderky marked this pull request as ready for review September 15, 2022 18:13
@crusaderky crusaderky self-assigned this Sep 15, 2022
@crusaderky
Copy link
Contributor Author

@fjetter @ian-r-rose @hendrikmakait @gjoseph92 @jrbourbeau @ncclementi

This is ready for review.
However, it heavily conflicts with #235, which has been just merged. I'll need an extra day (at least) to re-engineer it.

@crusaderky crusaderky changed the title [WIP] Repeat A/B tests Repeat A/B tests Sep 15, 2022
@crusaderky
Copy link
Contributor Author

crusaderky commented Sep 15, 2022

A/B tests evidence: https://github.com/coiled/coiled-runtime/actions/runs/3061990145

@fjetter
Copy link
Member

fjetter commented Sep 16, 2022

However, it heavily conflicts with #235, which has been just merged. I'll need an extra day (at least) to re-engineer it.

I believe these changes offer enough value to invest another day or two. We knew that there will be some migration effort before we started.

@crusaderky
Copy link
Contributor Author

Superseded by #355

@crusaderky crusaderky deleted the guido/AB_repeat branch September 22, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants