Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use spot + fallback + multizone for all clusters #514

Merged
merged 2 commits into from
Nov 16, 2022
Merged

Use spot + fallback + multizone for all clusters #514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7cafd0
Use spot + fallback + multizone for all clusters
ntabris Nov 10, 2022
422d06c
Merge branch 'main' into nat/spot-fallback-multizone-everywhere
ntabris Nov 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion tests/benchmarks/test_parquet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,11 @@ def parquet_cluster(dask_env_variables, gitlab_cluster_tags):
scheduler_vm_types=["m5.xlarge"],
package_sync=True,
environ=dask_env_variables,
backend_options={"send_prometheus_metrics": True},
backend_options={
"spot": True,
"spot_on_demand_fallback": True,
"multizone": True,
},
tags=gitlab_cluster_tags,
) as cluster:
yield cluster
Expand Down
4 changes: 3 additions & 1 deletion tests/stability/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@

def pytest_collection_modifyitems(config, items):
# Ensure stability tests use spot instances by default
marker = pytest.mark.backend_options(spot=True, spot_on_demand_fallback=True)
marker = pytest.mark.backend_options(
spot=True, spot_on_demand_fallback=True, multizone=True
)
for item in items:
# Add a module-level `spot=True` backend option marker if one doesn't already exist
module = item.parent
Expand Down
6 changes: 5 additions & 1 deletion tests/stability/test_spill.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,11 @@ def spill_cluster(dask_env_variables, gitlab_cluster_tags):
worker_vm_types=["m6i.large"],
scheduler_vm_types=["m6i.xlarge"],
wait_for_workers=True,
backend_options={"send_prometheus_metrics": True},
backend_options={
"spot": True,
"spot_on_demand_fallback": True,
"multizone": True,
},
environ=merge(
dask_env_variables,
{
Expand Down