Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove sharp #132

Merged
merged 3 commits into from
Aug 25, 2019
Merged

remove sharp #132

merged 3 commits into from
Aug 25, 2019

Conversation

coilysiren
Copy link
Owner

@coilysiren coilysiren commented Aug 25, 2019 •
edited
Loading

Changes

  • removes all the dependencies that were pulling in sharp, which were
    • gatsby-plugin-manifest (not sure why this one needed sharp)
    • gatsby-plugin-sharp
    • gatsby-transformer-sharp
  • removes gatsby-plugin-offline since it wasn't being used

Context

sharp was causing issues on people's local machines. We ran into this issue Automattic/node-canvas#930 and couldn't resolve it.

@coilysiren coilysiren requested a review from kefimochi August 25, 2019 20:15
@coilysiren coilysiren self-assigned this Aug 25, 2019
@coilysiren
Copy link
Owner Author

🚧 WIP still! need to update the lockfile 🚧

@coilysiren
Copy link
Owner Author

✔️

@coilysiren
Copy link
Owner Author

👀 I'm gonna merge this now!

@coilysiren coilysiren merged commit d3d346e into main Aug 25, 2019
@coilysiren coilysiren deleted the no-sharp branch September 10, 2019 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kefimochi kefimochi Awaiting requested review from kefimochi

Assignees

@coilysiren coilysiren

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@coilysiren