Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR builds fail when remote branch names contain special characters #22

Closed
jhmgoossens opened this issue May 17, 2023 · 4 comments
Closed

Comments

@jhmgoossens
Copy link

Linux and Windows CI builds for Pull Requests for all project fail if the remote branch name contains a forward slash / because such characters are valid for branch names but not for the uploaded PR asset names. See the discussion in PR 214 of CoinUtils.

This could be fixes by replacing such characters in the name of the uploaded PR assets, or by leaving out the remote branch name from the PR asset name altogether.

Since we rarely create PRs from branches with names like feature/foo this is not a very common issue.

@tkralphs
Copy link
Member

I was originally thinking of a single PR containing all the issues that we can add to over time. Otherwise, it may get a bit difficult to see at a glance how many issues have accumulated. An alternative would be to create a label for Actions-related issues. This is not a bad idea, actually. What do you prefer?

@jhmgoossens
Copy link
Author

I personally strongly prefer “one issue, one Issue” since this is far easier to tick off as fully Done (or not).

I wasn’t expecting that many issues, but indeed adding a label would be a good idea.

@tkralphs
Copy link
Member

The issues can accumulate fast :). Anyway, created the label gh-actions now.

@jhmgoossens
Copy link
Author

This can be closed. For PR builds, the remote branch name (head ref) was removed from the artifact names.
See coin-or/Clp@29b0bb8, coin-or/Cbc@eee5e3f, coin-or/CoinUtils@125379a, etc.
See also the discussion in Issue #25.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants