-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add VS2022 and its windows-ci to stable 2.11 #214
Add VS2022 and its windows-ci to stable 2.11 #214
Conversation
and remove VS2022 buildtools includes
Sorry to be a pain, but I guess that the Windows safe naming fix is also now not needed. Ideally, Windows and Linux would handle artifact naming in the same way, since this is independent of build platform. I guess that the first four commits here are the ones really needed. Maybe you would reset head back to 51f4346 and force push? |
I see what you mean. I’ll try to change the PR again or create a third PR if necessary. However, three points to keep in mind for the future:
|
I took the easy way out and simply added a commit to revert the windows-ci changes. I propose to squash and merge changes. |
OK, sure, I can squash and merge. Your points are valid and I agree that we should make a better fix eventually. Not including the remote branch name in the artifact name makes sense. If we either had a significant number of PRs coming in so that this could actually be an issue or more developer bandwidth, I would push something out more quickly. I do periodically push out new YAML files to all project when there are enough fixes to justify the effort, I just want to do this purposefully. Let's open an issue to keep track of all the things that should be fixed and then when that list has enough things on it, we can push out new YAML files to all projects. A logical place to open the issue would be in https://github.com/coin-or/Coin-OR-OptimizationSuite. And sure, I would appreciate the help with this! |
Great, thanks. I created the issues. I’ll now proceed with (just) the Cbc dependencies and their latest stables. |
While master branch has had VS2022 projects for some time, these were not in stable/2.11 since that was created before.
Added also windows-ci build msvs for VS2022 like master.
Included configall_system for MSC as in master.
PR builds failed due to package names (the "/" in remote branch name stable/2.11-dev made the original package name not valid). Fixed Windows ci builds, not in Linux ci (see #212 ).
The aim is to get Cbc stable/2.10 and all (stable) dependencies to have VS2022 projects where currently none do.
CoinUtils stable/2.11 is step 1.