Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure LibraryLoader looks for 'dll' extension when compiled with … #628

Closed
wants to merge 1 commit into from
Closed

Make sure LibraryLoader looks for 'dll' extension when compiled with … #628

wants to merge 1 commit into from

Conversation

jgillis
Copy link

@jgillis jgillis commented Jan 14, 2023

…mingw

@CLAassistant
Copy link

CLAassistant commented Jan 14, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

svigerske added a commit that referenced this pull request Jan 25, 2023
@svigerske
set sharedlib extension to dll whenever _WIN32, not only _MSC_VER, see …
5e97a69 
…#628
@svigerske
Copy link
Member

I committed 5e97a69 instead. That should be ok, or? You'll have _WIN32 defined when compiling with GCC under MinGW?

@svigerske svigerske closed this Feb 7, 2023
@svigerske
Copy link
Member

To answer my question. On my system, _WIN32 seems to be defined:

$ echo | gcc -dM -E - | grep WIN32
#define _WIN32 1
#define __WIN32 1
#define __WIN32__ 1
#define WIN32 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jgillis @CLAassistant @svigerske