Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HSL_MC68 header #653

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

jfowkes
Copy link
Member

@jfowkes jfowkes commented Apr 5, 2023

We have found a minor bug in the HSL_MC68 C header that we have been shipping to date, that is the control.min_l_workspace parameter had the wrong type in the C header. This has now been corrected so that it has integer type as is the case in the rest of the C interface and the Fortran code. Please see the HSL_MC68 changelog:
https://www.hsl.rl.ac.uk/catalogue/hsl_mc68.html

I can only assume that this optional parameter was not used as we would expect the mismatch in structs on the C and Fortran side to cause mangling of members in the C control struct (this is a major weakness of Fortran ISO C interfacing).

@svigerske svigerske merged commit 123c20c into coin-or:stable/3.14 Apr 5, 2023
@svigerske
Copy link
Member

Thanks. Indeed, it seems that only the f_array_in and f_array_out members are accessed by the HSL_MA77 and HSL_MA86 interfaces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants