change loadLibrary on Windows to LoadLibraryA + LoadLibraryExA again #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok for me. |
|
OK for me. Thanks! |
svigerske
force-pushed
the
759-update-loadlib-win
branch
from
ddf86e4 to
1622183
Compare
- try LoadLibraryA first in any case - try LoadLibraryExA if that failed - print error from both, unless second failed with invalid parameter error
svigerske
force-pushed
the
759-update-loadlib-win
branch
from
1622183 to
809110f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@metab0t @traversaro would this be ok for you?