-
-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more config parameters to HiGHS python API + set up logging #606
Add more config parameters to HiGHS python API + set up logging #606
Conversation
Hi @pchtsp - no rush, but let me know if this is good enough to be merged |
Hi @pchtsp - pinging again, would it be possible to merge those changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. I added just a minor comment on the arguments, so that it matches the other APIs structure (and also so it shows in the docs).
def __init__( | ||
self, | ||
mip=True, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we prefer having the explicit enumeration of parameters, together with a description. This produces the documentation of the APIs in the docs. It's the only way to know in the docs which parameters are supported and which ones are not.
See
Lines 296 to 316 in a017fdb
def __init__( | |
self, | |
mip=True, | |
msg=True, | |
timeLimit=None, | |
gapRel=None, | |
warmStart=False, | |
logPath=None, | |
epgap=None, | |
logfilename=None, | |
): | |
""" | |
:param bool mip: if False, assume LP even if integer variables | |
:param bool msg: if False, no log is shown | |
:param float timeLimit: maximum time for solver (in seconds) | |
:param float gapRel: relative gap tolerance for the solver to stop (in fraction) | |
:param bool warmStart: if True, the solver will use the current value of variables as a start | |
:param str logPath: path to the log file | |
:param float epgap: deprecated for gapRel | |
:param str logfilename: deprecated for logPath | |
""" |
b73e6d4
to
eb7edf3
Compare
@pchtsp - Thanks for the review, that makes a lot of sense! I've added the explicit parameters and docs back |
Hello again and sorry for the delay. In the meantime, we merged some other PRs for highs api. Can you fix the conflicts and re-merge? That way I can approve. thanks again! |
dfd66a7
to
665de2e
Compare
8ba2ef0
to
6f69ee2
Compare
6f69ee2
to
c6460a9
Compare
@pchtsp - all done |
Reference issue
#553 (sort of )
What does this implement?
Improves the usability of the HiGHS interface:
Any other comments
N/A