Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix removal of variables (#294) #296

Merged
merged 1 commit into from Aug 8, 2022
Merged

Fix removal of variables (#294) #296

merged 1 commit into from Aug 8, 2022

Conversation

sebheger
Copy link
Collaborator

@sebheger sebheger commented Jul 18, 2022

Fixes #294

@sebheger
Copy link
Collaborator Author

@Markus28 Could you provide the necessary unit-tests? You mentioned in #288 that you tested the complete removal workflow. Thanks!

@Markus28
Copy link
Contributor

In the test_remove method in test_model.py, just add the line m.remove(x) at the very bottom.

I'm not 100% sure what is supposed to happen when you remove a variable that is used in a constraint or the objective thought, so it might make sense to add a test for that case as well (e.g. if some exception is supposed to be raised).

@sebheger sebheger merged commit fcf728d into coin-or:master Aug 8, 2022
@sebheger sebheger deleted the fix_294 branch August 8, 2022 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

model.remove broken for variables in mip 1.14.0
2 participants