Skip to content

Conversation

@CarsonRoscoe
Copy link
Contributor

@CarsonRoscoe CarsonRoscoe commented May 28, 2025

Description

We received a report from TBA about improving our error handling in the Next generated chatbot. We wholeheartedly agree, and this seeks to improve it.

Tests

Now, when the UI runs into an issue, the error messages propagated come from checks in anticipation of these issues, and are readable non-vague instructions on overcoming the error.

Screenshot 2025-05-28 at 11 03 25 AM Screenshot 2025-05-28 at 11 37 17 AM Screenshot 2025-05-28 at 11 38 05 AM

Checklist

A couple of things to include in your PR for completeness:

  • Added documentation to all relevant README.md files
  • Added a changelog entry

@cb-heimdall
Copy link

cb-heimdall commented May 28, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@github-actions github-actions bot added documentation Improvements or additions to documentation action provider New action provider wallet provider New wallet provider example New example agent framework extension New framework extension typescript labels May 28, 2025
@CarsonRoscoe CarsonRoscoe changed the base branch from main to feat/rename-cdp-env-vars May 28, 2025 16:01
@CarsonRoscoe CarsonRoscoe marked this pull request as ready for review May 28, 2025 16:01
@CarsonRoscoe CarsonRoscoe requested a review from murrlincoln as a code owner May 28, 2025 16:01
@github-actions github-actions bot removed action provider New action provider wallet provider New wallet provider example New example agent framework extension New framework extension labels May 28, 2025
@CarsonRoscoe CarsonRoscoe changed the title Feat/next template error handling feat: improved error handling in next template of cli May 28, 2025
Base automatically changed from feat/rename-cdp-env-vars to main May 28, 2025 17:22
@CarsonRoscoe CarsonRoscoe force-pushed the feat/next-template-error-handling branch from a289146 to 74dd287 Compare May 28, 2025 17:22
@CarsonRoscoe CarsonRoscoe requested a review from avidreder May 28, 2025 17:23
Copy link

@avidreder avidreder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CarsonRoscoe CarsonRoscoe merged commit 8da312c into main May 28, 2025
28 checks passed
@CarsonRoscoe CarsonRoscoe deleted the feat/next-template-error-handling branch May 28, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation typescript

Development

Successfully merging this pull request may close these issues.

3 participants