Merge pull request #91 from coinbase/derauk/ruby3-compat

Fix deprecation warnings for ruby3 compatibility

spec/unit/lib/cadence/activity/context_spec.rb

@@ -5,7 +5,7 @@
 describe Cadence::Activity::Context do
   let(:connection) { instance_double('Cadence::Connection::Thrift') }
   let(:metadata_hash) { Fabricate(:activity_metadata).to_h }
-  let(:metadata) { Cadence::Metadata::Activity.new(metadata_hash) }
+  let(:metadata) { Cadence::Metadata::Activity.new(**metadata_hash) }
   let(:task_token) { SecureRandom.uuid }
 
   subject { described_class.new(connection, metadata) }

spec/unit/lib/cadence/activity/poller_spec.rb

@@ -51,7 +51,7 @@
         .to have_received(:timing)
         .with(
           'activity_poller.time_since_last_poll',
-          an_instance_of(Fixnum),
+          an_instance_of(Integer),
           domain: domain,
           task_list: task_list
         )

spec/unit/lib/cadence/activity/workflow_convenience_methods_spec.rb

@@ -20,7 +20,7 @@ class TestActivity < Cadence::Activity; end
       end
 
       it 'executes activity' do
-        subject.execute(input, options)
+        subject.execute(input, **options)
 
         expect(context)
           .to have_received(:execute_activity)
@@ -47,7 +47,7 @@ class TestActivity < Cadence::Activity; end
       end
 
       it 'executes activity' do
-        subject.execute!(input, options)
+        subject.execute!(input, **options)
 
         expect(context)
           .to have_received(:execute_activity!)
@@ -60,7 +60,7 @@ class TestActivity < Cadence::Activity; end
 
       it 'raises an error' do
         expect do
-          subject.execute!(input, options)
+          subject.execute!(input, **options)
         end.to raise_error('Called Activity#execute! outside of a Workflow context')
       end
     end
@@ -74,7 +74,7 @@ class TestActivity < Cadence::Activity; end
       end
 
       it 'executes activity' do
-        subject.execute_locally(input, options)
+        subject.execute_locally(input, **options)
 
         expect(context)
           .to have_received(:execute_local_activity)
@@ -87,7 +87,7 @@ class TestActivity < Cadence::Activity; end
 
       it 'raises an error' do
         expect do
-          subject.execute_locally(input, options)
+          subject.execute_locally(input, **options)
         end.to raise_error('Called Activity#execute_locally outside of a Workflow context')
       end
     end

spec/unit/lib/cadence/crew_spec.rb

@@ -79,7 +79,7 @@
       end
 
       it 'skips the after_fork block if not set' do
-        crew.should_receive(:fork) do |&block|
+        expect(crew).to receive(:fork) do |&block|
           expect(worker).to receive(:start)
           expect(crew.send(:after_fork_block)).to be_nil
           block.call
@@ -96,7 +96,7 @@
 
         crew.after_fork &after_fork_block
 
-        crew.should_receive(:fork) do |&block|
+        expect(crew).to receive(:fork) do |&block|
           block.call
           expect(executed).to eq(true)
           expect(worker).to have_received(:start)

spec/unit/lib/cadence/metadata/activity_spec.rb

@@ -1,7 +1,7 @@
 require 'cadence/metadata/activity'
 
 describe Cadence::Metadata::Activity do
-  subject { described_class.new(args.to_h) }
+  subject { described_class.new(**args.to_h) }
   let(:args) { Fabricate(:activity_metadata) }
 
   describe '#initialize' do

spec/unit/lib/cadence/metadata/decision_spec.rb

@@ -1,7 +1,7 @@
 require 'cadence/metadata/decision'
 
 describe Cadence::Metadata::Decision do
-  subject { described_class.new(args.to_h) }
+  subject { described_class.new(**args.to_h) }
   let(:args) { Fabricate(:decision_metadata) }
 
   describe '#initialize' do

spec/unit/lib/cadence/metadata/workflow_spec.rb

@@ -1,7 +1,7 @@
 require 'cadence/metadata/workflow'
 
 describe Cadence::Metadata::Workflow do
-  subject { described_class.new(args.to_h) }
+  subject { described_class.new(**args.to_h) }
   let(:args) { Fabricate(:workflow_metadata) }
 
   describe '#initialize' do

spec/unit/lib/cadence/worker_spec.rb

@@ -174,7 +174,7 @@ class TestWorkerActivity < Cadence::Activity
     end
 
     context 'with options' do
-      subject { described_class.new(config, options) }
+      subject { described_class.new(config, **options) }
       let(:options) { { polling_ttl: 42, thread_pool_size: 42 } }
 
       before do

spec/unit/lib/cadence/workflow/context_spec.rb

@@ -19,7 +19,7 @@
         headers: { 'TestHeader' => 'Value' }
       }
     end
-    let(:metadata) { Cadence::Metadata::Workflow.new(metadata_hash) }
+    let(:metadata) { Cadence::Metadata::Workflow.new(**metadata_hash) }
     let(:config) { Cadence::Configuration.new }
 
     describe '#headers' do

spec/unit/lib/cadence/workflow/convenience_methods_spec.rb

@@ -20,7 +20,7 @@ class TestWorkflow < Cadence::Workflow; end
       end
 
       it 'executes activity' do
-        subject.execute(input, options)
+        subject.execute(input, **options)
 
         expect(context)
           .to have_received(:execute_workflow)
@@ -47,7 +47,7 @@ class TestWorkflow < Cadence::Workflow; end
       end
 
       it 'executes activity' do
-        subject.execute!(input, options)
+        subject.execute!(input, **options)
 
         expect(context)
           .to have_received(:execute_workflow!)
@@ -60,7 +60,7 @@ class TestWorkflow < Cadence::Workflow; end
 
       it 'raises an error' do
         expect do
-          subject.execute!(input, options)
+          subject.execute!(input, **options)
         end.to raise_error('Called Workflow#execute! outside of a Workflow context')
       end
     end

spec/unit/lib/cadence/workflow/poller_spec.rb

@@ -56,7 +56,7 @@
         .to have_received(:timing)
         .with(
           'workflow_poller.time_since_last_poll',
-          an_instance_of(Fixnum),
+          an_instance_of(Integer),
           domain: domain,
           task_list: task_list
         )