Skip to content

fix: harden ZK verifiers and crypto primitives #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hsiuhsiu wants to merge 1 commit into from
Closed

fix: harden ZK verifiers and crypto primitives #82

hsiuhsiu wants to merge 1 commit into from

Conversation

@hsiuhsiu
Copy link
Contributor

@hsiuhsiu hsiuhsiu commented Jan 6, 2026

  • Add parameter validation in ZK verifiers (rho, b bounds, overflow checks)
  • Add range checks for proof elements (e, z values) before use
  • Add curve point validation for commitment elements (R, A, B arrays)
  • Fix secp256k1 mul_add to handle edge cases in vartime/verifier paths
  • Fix bn_t::from_bin_bitlen to handle 0-bit input without OOB access
  • Reject mod_t deserialization when modulus <= 1

@hsiuhsiu
fix: harden ZK verifiers and crypto primitives
f4832cc 
- Add parameter validation in ZK verifiers (rho, b bounds, overflow checks)
- Add range checks for proof elements (e, z values) before use
- Add curve point validation for commitment elements (R, A, B arrays)
- Fix secp256k1 mul_add to handle edge cases in vartime/verifier paths
- Fix bn_t::from_bin_bitlen to handle 0-bit input without OOB access
- Reject mod_t deserialization when modulus <= 1
@cb-heimdall
Copy link

cb-heimdall commented Jan 6, 2026 •
edited
Loading

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/2
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 2
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 1
Global minimum 0
Max 2
2
1 if commit is unverified 0
Sum 2
CODEOWNERS ✅ None for this change

@hsiuhsiu hsiuhsiu marked this pull request as ready for review January 6, 2026 05:46
@hsiuhsiu hsiuhsiu closed this Jan 7, 2026
@Arash-Afshar Arash-Afshar deleted the fix-zk branch January 8, 2026 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hsiuhsiu @cb-heimdall