Add permissions to npm-publish action to enable provenance #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveviselli-cb
requested review from
sumxu96,
zack-winchell-cb and
patricktruong-cb
sumxu96
approved these changes
Jun 12, 2024
patricktruong-cb
approved these changes
Jun 12, 2024
zack-winchell-cb
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
Our new NPM publish workflow failed because of some missing permissions:
https://github.com/coinbase/cbpay-js/actions/runs/9489681461/job/26151544199
The fix for this is documented here - https://docs.npmjs.com/generating-provenance-statements
Testing & documentation