Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(PSDK-584): Read contract support #29

Merged
merged 9 commits into from
Oct 17, 2024
Merged

feat(PSDK-584): Read contract support #29

merged 9 commits into from
Oct 17, 2024

Conversation

rohan-agarwal-coinbase
Copy link
Contributor

@rohan-agarwal-coinbase rohan-agarwal-coinbase commented Oct 16, 2024 •
edited
Loading

What changed? Why?

  • Added read_contract function to smart_contract.py

Testing

  • Unit tests
  • Tested e2e with my backend service changes

Qualified Impact

@cb-heimdall
Copy link

cb-heimdall commented Oct 16, 2024 •
edited
Loading

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@rohan-agarwal-coinbase rohan-agarwal-coinbase marked this pull request as ready for review October 17, 2024 03:48
@rohan-agarwal-coinbase rohan-agarwal-coinbase changed the base branch from master to v0.0.6 October 17, 2024 13:16
@rohan-agarwal-coinbase rohan-agarwal-coinbase changed the title feat(PSDK-584): Read Contract support feat(PSDK-584): Read contract support Oct 17, 2024
@rohan-agarwal-coinbase rohan-agarwal-coinbase merged commit cb82eb1 into v0.0.6 Oct 17, 2024
7 checks passed
rohan-agarwal-coinbase added a commit that referenced this pull request Oct 17, 2024
@rohan-agarwal-coinbase
Release v0.0.6 (#31)
dbd42d4 
* feat(PSDK-584): Read contract support (#29)

* Update to 0.0.6 and update docs and changelog (#30)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@John-peterson-coinbase John-peterson-coinbase John-peterson-coinbase approved these changes

@alex-stone alex-stone Awaiting requested review from alex-stone

@jazz-cb jazz-cb Awaiting requested review from jazz-cb

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rohan-agarwal-coinbase @cb-heimdall @John-peterson-coinbase