Skip to content

Conversation

@wisefool769
Copy link

@wisefool769 wisefool769 commented Aug 19, 2025

Description

Improves typing to enable library to be used in projects with a stricter TSConfig. Also makes the TSConfig stricter in this repo so this doesn't drift in the future. Some of these were preventing me from using cdp-sdk in my project without a patch.

Closes #410 and #345

Tests

  # Standard TypeScript check:
  npx tsc --noEmit

  # Strict TypeScript check (the key one that caught all the original errors):
  npx tsc --noEmit --noImplicitAny --noImplicitReturns --noImplicitThis

  # Code Quality Tests

  # ESLint (including Prettier formatting):
  pnpm lint

  # Auto-fix linting issues:
  pnpm lint:fix

Checklist

A couple of things to include in your PR for completeness:

  • Updated the typescript README if relevant (Not applicable)
  • Updated the python README if relevant (Not applicable)
  • Added a changelog entry
  • Added e2e tests if introducing new functionality (Not Applicable)

@cb-heimdall
Copy link

cb-heimdall commented Aug 19, 2025

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@wisefool769 wisefool769 force-pushed the wisefool769/typescript-fixes branch from 97e2293 to daa1efb Compare August 25, 2025 18:15
@0xRAG 0xRAG mentioned this pull request Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Typescript Error

2 participants