fix: don't look at random/motion based stories for visreg #263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
🟡 Heimdall Review Status
🟡
|
| Code Owner | Status | Calculation | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| ui-systems-eng-team |
🟡
0/1
|
Denominator calculation
|
| 'Interactive/TextInput', | ||
| 'Interactive/Select', | ||
| 'Components/Modal', | ||
| // Animation and randomized examples aren't reliable for visual regression testing |
Contributor
There was a problem hiding this comment.
Does rolling number stories also random and break visreg?
Contributor
Author
There was a problem hiding this comment.
The only ones that break are ones that automatically animate - I think the only rolling number one that does this is the countdown but this hasn't been flaky. I'm thinking maybe because it's timer based it is reliably not animating at the time the screenshot is taken?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Root cause (required for bugfixes)
These tests relied on random data and/or motion, which wasn't properly being captured in Percy. Future work is planned to support prefers reduced motion and we can revisit then capturing the affected components.
UI changes
Testing
How has it been tested?
Testing instructions
Illustrations/Icons Checklist
Required if this PR changes files under
packages/illustrations/**orpackages/icons/**Change management
type=routine
risk=low
impact=sev5
automerge=false