Skip to content

Conversation

@bpk9
Copy link

@bpk9 bpk9 commented Dec 30, 2025

What changed? Why?

  • Added logic to handle the disableAnimateOnMount prop on the web ProgressCircle component.

Root cause (required for bugfixes)

  • The disableAnimateOnMount prop was not implemented on the web ProgressCircle component.

UI changes

Before After
Before.mov
After.mov

Testing

How has it been tested?

  • Unit tests
  • Interaction tests
  • Pseudo State tests
  • Manual - Web
  • Manual - Android (Emulator / Device)
  • Manual - iOS (Emulator / Device)

Testing instructions

  1. Run the storybook app locally via yarn nx run storybook:start
  2. Verify the "ProgressBar - Disable Animate On Mount" story behaves as expected

Change management

type=routine
risk=low
impact=sev5

automerge=false

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Dec 30, 2025

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 1
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1
CODEOWNERS 🟡 See below

🟡 CODEOWNERS

Code Owner Status Calculation
ui-systems-eng-team 🟡 0/1
Denominator calculation
Additional CODEOWNERS Requirement
Show calculation
Sum 0
0
From CODEOWNERS 1
Sum 1

@bpk9 bpk9 changed the title fix: disable animate on mount for ProgressCircle fix: handle disableAnimateOnMount prop for web ProgressCircle Dec 30, 2025
@bpk9
Copy link
Author

bpk9 commented Dec 31, 2025

If aligned, we should consider a similar fix for mobile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants