Skip to content

Conversation

@stacysun-cb
Copy link
Contributor

@stacysun-cb stacysun-cb commented Jan 8, 2026

What changed? Why?

Add chained modals story

VoiceOver recording

Screen.Recording.2026-01-08.at.2.09.30.PM.mov

Doc site update

Screenshot 2026-01-08 at 3 36 03 PM

Testing

How has it been tested?

  • Unit tests
  • Interaction tests
  • Pseudo State tests
  • Manual - Web
  • Manual - Android (Emulator / Device)
  • Manual - iOS (Emulator / Device)

Testing instructions

Illustrations/Icons Checklist

Required if this PR changes files under packages/illustrations/** or packages/icons/**

  • verified visreg changes with Terran (include link to visreg run/approval)
  • all illustration/icons names have been reviewed by Dom and/or Terran

Change management

type=routine
risk=low
impact=sev5

automerge=false

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Jan 8, 2026

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 1
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1
CODEOWNERS ✅ See below

CODEOWNERS

Code Owner Status Calculation
ui-systems-eng-team 1/1
Denominator calculation
Additional CODEOWNERS Requirement
Show calculation
Sum 0
0
From CODEOWNERS 1
Sum 1

hcopp
hcopp previously approved these changes Jan 8, 2026
Copy link
Contributor

@hcopp hcopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This example looks great, thanks for the video recording!

I could also see users benefit from this being in documentation

@stacysun-cb
Copy link
Contributor Author

This example looks great, thanks for the video recording!

I could also see users benefit from this being in documentation

Thanks! Updated to doc site.

@stacysun-cb stacysun-cb merged commit a116990 into master Jan 8, 2026
17 checks passed
@stacysun-cb stacysun-cb deleted the stacy/add-modal-story branch January 8, 2026 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants