Skip to content
This repository has been archived by the owner on Jan 20, 2020. It is now read-only.

getFills: update typescript signature #196

Closed
jkuchar opened this issue Jan 2, 2018 · 2 comments
Closed

getFills: update typescript signature #196

jkuchar opened this issue Jan 2, 2018 · 2 comments
Labels
typescript-definitions

Comments

@jkuchar
Copy link

jkuchar commented Jan 2, 2018 •
edited
Loading

There is noway how to specify product/orderId (which is supported by the API) for getFills() method because there is only PageArgs arguments type.
@rmm5t
Copy link
Contributor

rmm5t commented Jan 3, 2018

A pull-request is very much welcome here.

<rant> Ugh, TypeScript is such a disaster, and far too limiting for a wrapper library around changing RESTful APIs. It pretty much guarantees forwards compatibility issues. </rant>

aricallen added a commit to aricallen/gdax-node that referenced this issue Oct 14, 2018
@aricallen
Fixes coinbase#196 - add optional order_id param to getFills as suppo…
c7aa22f 
…rted by the API
@fb55
Copy link
Contributor

fb55 commented Oct 14, 2018

Fixed on master

@fb55 fb55 closed this as completed Oct 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
typescript-definitions
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rmm5t @jkuchar @fb55