Refactor session config handling and cryptography logic for improved abstraction #1059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/wallet-sdk/src/connection/WalletLinkConnection.ts
rename
bangtoven
force-pushed
the
jungho/abstract-websocket-stuff
branch
from
77c29db to
82d231c
Compare
bangtoven
commented
Nov 11, 2023
bangtoven
force-pushed
the
jungho/abstract-websocket-stuff
branch
from
72dc289 to
d8d771b
Compare
bangtoven
commented
Nov 11, 2023
bangtoven
force-pushed
the
jungho/abstract-websocket-stuff
branch
from
3b45dff to
a316bc9
Compare
bangtoven
force-pushed
the
jungho/abstract-websocket-stuff
branch
2 times, most recently
from
5b994c2 to
f88c1bf
Compare
bangtoven
force-pushed
the
jungho/abstract-websocket-stuff
branch
from
f88c1bf to
60c8d1a
Compare
bangtoven
changed the title
# Conflicts: # packages/wallet-sdk/jest.config.ts # packages/wallet-sdk/src/connection/WalletLinkConnection.ts
bangtoven
commented
Nov 13, 2023
| @@ -5,4 +5,15 @@ module.exports = { | |||
| pragma: "h", | |||
| }, | |||
| }, | |||
| rules: { | |||
| 'no-useless-constructor': 'off', | |||
There was a problem hiding this comment.
i know what's useless or not
bangtoven
requested review from
fan-zhang-sv,
erin-at-work,
willnewman-cb,
spencerstock and
gaurav-cb
bangtoven
commented
Nov 13, 2023
| "@typescript-eslint/no-explicit-any": "off" | ||
| } | ||
| } | ||
| ] |
There was a problem hiding this comment.
fan-zhang-sv
approved these changes
Nov 13, 2023
This was referenced Nov 14, 2023
bangtoven
added a commit
that referenced
this pull request
Feb 29, 2024
bangtoven
added a commit
that referenced
this pull request
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://coinbase.slack.com/archives/C03QN57NMHV/p1699906732036009
RelaytoConnectionRelaytoConnectionHow did you test your changes?
new & existing tests