Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove bn.js dep #1083

Closed
wants to merge 7 commits into from
Closed

remove bn.js dep #1083

wants to merge 7 commits into from

Conversation

bangtoven
Copy link
Contributor

@bangtoven bangtoven commented Nov 23, 2023

Summary

will revisit how to replace bn.js on abi.js file

How did you test your changes?

Copy link

@Isis831 Isis831 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

Copy link

@Isis831 Isis831 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@@ -1,8 +1,6 @@
// Copyright (c) 2018-2023 Coinbase, Inc. <https://www.coinbase.com/>
// Licensed under the Apache License, version 2.0

import BN from 'bn.js';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@bangtoven bangtoven closed this Feb 29, 2024
@bangtoven bangtoven deleted the jungho/remove-BN branch February 29, 2024 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants