initialize SCWStateManager with dapp chainIds #1134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nateReiners
approved these changes
Mar 18, 2024
| @@ -41,7 +41,7 @@ export class SCWStateManager { | |||
| } | |||
There was a problem hiding this comment.
nit would place updateListeners after _activeChain and _accounts are set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We follow the app's
chainIdsparam to set the default network for SDK, but we missed out SCWStateManager, so it's always sending requests on mainnet. This PR updated SCWStateManager to takechainIdsfor fallbackHow did you test your changes?
Manually