Fix popup blocked on Safari #1294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nateReiners
reviewed
May 20, 2024
bangtoven
reviewed
May 20, 2024
There was a problem hiding this comment.
thanks for opening PR up. @arjun-dureja
happy to pair if you are down.
| @@ -62,24 +62,10 @@ export class Communicator { | |||
| }); | |||
| }; | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
we don't need to move this
There was a problem hiding this comment.
I moved it down since it's the only private method in the class now
|
@bangtoven for sake of speed, maybe you should take over PR with the changes you want? Not sure what else @arjun-dureja has on plate today |
bangtoven
reviewed
May 20, 2024
bangtoven
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SCWSigner. Safari blocks it because it is not opened immediately after a button is clicked.requestmethod so that it first opens the popup and then constructs the request. This is how it was done before this PRHow did you test your changes?
Screen.Recording.2024-05-19.at.6.20.56.PM.mov
Screen.Recording.2024-05-19.at.6.22.55.PM.mov