Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There's an issue on iPads where the object returned from
window.open
stays defined even after the window/tab is closed. This causes the popup to not be opened when one was opened in the past due to this line of code:coinbase-wallet-sdk/packages/wallet-sdk/src/core/communicator/Communicator.ts
Lines 82 to 83 in 53f3774
To solve this, I added a check for
popup.closed
on the same line, so that the popup is opened again when it's closedHow did you test your changes?
Screen.Recording.2024-05-22.at.2.12.03.PM.mov
Screen.Recording.2024-05-22.at.2.12.40.PM.mov