Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#trivial remove unnecessary catch / throw #1333

Merged
merged 2 commits into from
Jun 28, 2024
Merged

#trivial remove unnecessary catch / throw #1333

merged 2 commits into from
Jun 28, 2024

Conversation

bangtoven
Copy link
Contributor

@bangtoven bangtoven commented Jun 28, 2024 •
edited
Loading

Summary

separating out from #1331

How did you test your changes?

existing tests

bangtoven added 2 commits June 27, 2024 18:30
@bangtoven
checkErrorForInvalidRequestArgs
35d4a29 
commit 5415ceb
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Thu Jun 27 18:27:36 2024 -0700

    fix tests

commit 114e71d
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Thu Jun 27 18:02:47 2024 -0700

    min diff

commit bd0c5d9
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Thu Jun 27 17:52:17 2024 -0700

    wl

commit 7273f82
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Thu Jun 27 17:45:46 2024 -0700

    nits

commit 4432c16
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Thu Jun 27 17:39:22 2024 -0700

    fix tests

commit d86cf38
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Thu Jun 27 17:22:35 2024 -0700

    fix

commit 4d71a82
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Thu Jun 27 15:47:20 2024 -0700

    revert

commit 5ac4850
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Thu Jun 27 15:28:45 2024 -0700

    remove accounts / chains from provider

commit dc33d63
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Wed Jun 26 21:18:17 2024 -0700

    fix conflicts

commit ce45d78
Merge: 57b5d14 05a0263
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Wed Jun 26 21:12:12 2024 -0700

    Merge branch 'jungho/states' into jungho/dash

    # Conflicts:
    #	packages/wallet-sdk/src/CoinbaseWalletProvider.ts
    #	packages/wallet-sdk/src/sign/interface.ts
    #	packages/wallet-sdk/src/sign/scw/SCWSigner.ts
    #	packages/wallet-sdk/src/sign/scw/SCWStateManager.test.ts
    #	packages/wallet-sdk/src/sign/scw/SCWStateManager.ts

commit 57b5d14
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Wed Jun 26 21:06:03 2024 -0700

    nit

commit 19667e5
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Wed Jun 26 21:01:27 2024 -0700

    cleanup

commit ee74abb
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Wed Jun 26 20:58:30 2024 -0700

    handleSwitchChainRequest

commit 9add272
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Wed Jun 26 20:23:38 2024 -0700

    cleanup

commit 851f8ce
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Wed Jun 26 19:52:14 2024 -0700

    wip

commit 4738bb3
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Wed Jun 26 19:15:43 2024 -0700

    deprecate SCWStateManager and conslidate into SCWSigner

commit 6ad7ebc
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Wed Jun 26 17:34:50 2024 -0700

    ohwell

commit dd81af0
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Wed Jun 26 17:30:55 2024 -0700

    fix test

commit dbfdd44
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Wed Jun 26 17:11:52 2024 -0700

    simplify update listener by removing `source` param

    update listener interface

    remove source=storage case

    deprecate source

commit 05a0263
Merge: eb144d1 2afc1dd
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Wed Jun 26 16:55:53 2024 -0700

    Merge branch 'master' into jungho/states

    # Conflicts:
    #	packages/wallet-sdk/src/CoinbaseWalletProvider.test.ts
    #	packages/wallet-sdk/src/CoinbaseWalletProvider.ts
    #	packages/wallet-sdk/src/sign/interface.ts
    #	packages/wallet-sdk/src/sign/scw/SCWSigner.ts
    #	packages/wallet-sdk/src/sign/util.ts
    #	packages/wallet-sdk/src/sign/walletlink/WalletLinkSigner.ts

commit eb144d1
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Wed Jun 26 16:49:12 2024 -0700

    Revert "merge conflict res"

    This reverts commit 5fcf3fe.

commit 5fcf3fe
Author: Nate Reiners <nate.reiners@coinbase.com>
Date:   Wed Jun 26 12:14:46 2024 -0700

    merge conflict res

commit 440aa8a
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Fri May 3 17:30:24 2024 -0700

    wip

commit 7dfd645
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Fri May 3 16:51:49 2024 -0700

    cleanpup

commit 545fde9
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Fri May 3 16:46:01 2024 -0700

    move accounts chain state management to each Signer

commit 4235ddc
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Fri May 3 16:07:18 2024 -0700

    fix

commit acb41df
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Fri May 3 16:02:45 2024 -0700

    fix

commit 5688527
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Fri May 3 16:00:31 2024 -0700

    min diff

commit 385f958
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Fri May 3 15:58:48 2024 -0700

    revert moving

commit a5ac688
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Fri May 3 15:57:04 2024 -0700

    move

commit 4ac35cb
Author: Jungho Bang <jungho.bang@coinbase.com>
Date:   Fri May 3 15:53:49 2024 -0700

    consolidate wlrelayadapter and wlsigner
@bangtoven
cleanup
a31b6c2
@bangtoven bangtoven marked this pull request as ready for review June 28, 2024 01:35
bangtoven
bangtoven commented Jun 28, 2024
View reviewed changes
packages/wallet-sdk/src/CoinbaseWalletProvider.ts
return Promise.reject(serializeError(error, args.method));
}
}

protected readonly handlers = {
// eth_requestAccounts
handshake: async (_: RequestArguments): Promise<AddressString[]> => {
try {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/coinbase/coinbase-wallet-sdk/pull/1333/files?diff=split&w=1

nateReiners
nateReiners reviewed Jun 28, 2024
View reviewed changes
packages/wallet-sdk/src/CoinbaseWalletProvider.ts
@@ -146,6 +136,7 @@ export class CoinbaseWalletProvider extends EventEmitter implements ProviderInte
async disconnect(): Promise<void> {
this.accounts = [];
this.chain = { id: 1 };
this.signer?.disconnect();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this wasn't present before?! good catch

nateReiners
nateReiners previously approved these changes Jun 28, 2024
View reviewed changes
@cb-heimdall
Copy link
Collaborator

Review Error for nateReiners @ 2024-06-28 18:21:36 UTC
User failed mfa authentication, public email is not set on your github profile. see go/mfa-help

@nateReiners nateReiners self-requested a review June 28, 2024 18:27
@nateReiners nateReiners dismissed their stale review June 28, 2024 18:27

noticed error isn't being thrown

@bangtoven bangtoven enabled auto-merge (squash) June 28, 2024 18:37
@bangtoven bangtoven requested a review from vishnumad June 28, 2024 20:07
@cb-heimdall
Copy link
Collaborator

Review Error for nateReiners @ 2024-06-28 20:14:34 UTC
User failed mfa authentication, public email is not set on your github profile. see go/mfa-help

@cb-heimdall
Copy link
Collaborator

Review Error for nateReiners @ 2024-06-28 20:32:44 UTC
User failed mfa authentication, public email is not set on your github profile. see go/mfa-help

@bangtoven bangtoven merged commit e71ecec into master Jun 28, 2024
8 of 9 checks passed
@bangtoven bangtoven deleted the jungho/checkErrorForInvalidRequestArgs branch June 28, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nateReiners nateReiners nateReiners approved these changes

@fan-zhang-sv fan-zhang-sv Awaiting requested review from fan-zhang-sv

@erin-at-work erin-at-work Awaiting requested review from erin-at-work

@vishnumad vishnumad Awaiting requested review from vishnumad

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bangtoven @cb-heimdall @nateReiners