Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ExtensionSigner #1353

Merged
merged 3 commits into from
Jul 26, 2024
Merged

Remove ExtensionSigner #1353

merged 3 commits into from
Jul 26, 2024

Conversation

nateReiners
Copy link
Contributor

@nateReiners nateReiners commented Jul 25, 2024 •
edited
Loading

Summary

How did you test your changes?

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Jul 25, 2024 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@nateReiners nateReiners changed the title accomodate extension provider request return type for accounts and ch… Don't use deprecated extension provider methods, handle promise return type for getters Jul 25, 2024
@nateReiners nateReiners changed the title Don't use deprecated extension provider methods, handle promise return type for getters Don't use deprecated extension provider methods Jul 25, 2024
@nateReiners nateReiners marked this pull request as ready for review July 25, 2024 22:50
@nateReiners nateReiners changed the title Don't use deprecated extension provider methods Improve Signer getters Jul 25, 2024
bangtoven
bangtoven suggested changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@bangtoven bangtoven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's revisit

packages/wallet-sdk/src/sign/interface.ts Outdated Show resolved Hide resolved
packages/wallet-sdk/src/CoinbaseWalletProvider.ts Outdated Show resolved Hide resolved
@cb-heimdall
Copy link
Collaborator

Review Error for bangtoven @ 2024-07-25 23:02:51 UTC
User failed mfa authentication, see go/mfa-help

@nateReiners nateReiners force-pushed the nate/asyncAccountsAndChainGetters branch from c627d48 to 37c1b9e Compare July 26, 2024 22:42
@nateReiners nateReiners changed the title Improve Signer getters Remove ExtensionSigner Jul 26, 2024
@nateReiners nateReiners requested a review from bangtoven July 26, 2024 22:43
bangtoven
bangtoven approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@bangtoven bangtoven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty @nateReiners
this reminds me, let's revert the makeProvider changes and make it identical to the public version we've released. will file ticket for this. let's tackle it next week.

@nateReiners nateReiners merged commit 24a4dbe into master Jul 26, 2024
9 checks passed
@nateReiners nateReiners deleted the nate/asyncAccountsAndChainGetters branch July 26, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bangtoven bangtoven bangtoven approved these changes

@fan-zhang-sv fan-zhang-sv Awaiting requested review from fan-zhang-sv

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nateReiners @cb-heimdall @bangtoven