RN Cipher

[fan-zhang-sv]

Summary

Reimplemented Cipher for RN using @noble/curves

How did you test your changes?

Manually + Unit Test

[cb-heimdall]

✅ Heimdall Review Status

Requirement	Status	More Info
Reviews	✅ 1/1	Denominator calculation Show calculation 1 if user is bot 0 1 if user is external 0 From .codeflow.yml 1 Additional review requirements Show calculation Max 0 0 From CODEOWNERS 0 Global minimum 0 Max 1 1 1 if commit is unverified 0 Sum 1

[fan-zhang-sv]

this is a tiny library to polyfill the crypto.getRandomValues from "expo-crypto" on RN, which is needed in "@noble/curves" to provide randomness. On Node env, this does nothing

[talentlessguy]

this could be moved to optional dependencies instead since nothing besides React Native needs it

[talentlessguy]

or ideally polyfilling Web Crypto should be done not by a library but a React Native application. It's not a library's job to polyfill functionality imo

[fan-zhang-sv]

thx @talentlessguy, agreed and we will omit the polyfill here!

also would like to know your view on the approach we took on RN Cipher if possible. Generally we will ask consumer to provide randomness and use @noble/curves to achieve diffie hellman, do you have any concern or maybe you know any potential hiccup in this approach?

[talentlessguy]

perhaps there's no guarantee that provided randomness is random enough and isn't using something like Math.random()

[fan-zhang-sv]

JSON.stringify cannot handle ArrayBuffer, using Uint8Array to transmit the data

[fan-zhang-sv]

i tried!