Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disconnect to reset state completely #1367

Merged
merged 3 commits into from
Aug 5, 2024
Merged

Disconnect to reset state completely #1367

merged 3 commits into from
Aug 5, 2024

Conversation

fan-zhang-sv
Copy link
Contributor

Summary

found an issue caused by disconnect not able to reset completely

How did you test your changes?

Manually + Unit Tests

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Aug 5, 2024 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@fan-zhang-sv fan-zhang-sv merged commit e296efa into master Aug 5, 2024
8 checks passed
@fan-zhang-sv fan-zhang-sv deleted the felix/disconnect branch August 5, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishnumad vishnumad vishnumad approved these changes

@bangtoven bangtoven Awaiting requested review from bangtoven

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fan-zhang-sv @cb-heimdall @vishnumad