-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Communicator to include app metadata #1385
Conversation
✅ Heimdall Review Status
|
c079821
to
3b7737b
Compare
3b7737b
to
c6e11a7
Compare
this.url = new URL(url); | ||
this.metadata = metadata; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i wonder whether this needs to be a param of waitForPopupLoaded
method, not in constructor level.
(btw, we might rename the method to be, initialize or connect maybe??)
@cb-jake
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bangtoven If we made it a param of waitForPopupLoaded
we would probably need to make it a param postMessage
as well which would require passing it on calls to postMessage
. Currently we call waitForPopupLoaded
in 2 places, though one of those places is inside the communicators postmessage method which is called in 4 spots. I'm not positive we would have access to the metadata in all spots we call these methods
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should revisit Communicator's implementation so that we can understand when it should pass metadata to popup. probably only for onboarding or handshake, not all messages.
Summary
This change initializes the communicator with the app metadata. This provides app metadata to the onboarding screen on keys.coinbase.com
How did you test your changes?
Testing these changes requires running a few apps: